Skip to content

feature(appengine): Update quickstart samples to Nodejs24 #4192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iennae merged 3 commits into from
Nov 4, 2025
Merged

feature(appengine): Update quickstart samples to Nodejs24 #4192

iennae merged 3 commits into from
Nov 4, 2025

Conversation

@srinjoyray
Copy link
Contributor

@srinjoyray srinjoyray commented Nov 3, 2025 •
edited
Loading

Description

Nodejs 24 is going to GA for GAE Standard, Flex, GCF, Cloud Run and CRF.

Checklist

  • [x ] I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@srinjoyray srinjoyray requested review from a team as code owners November 3, 2025 17:12
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. asset: pattern DEE Asset tagging - Pattern. labels Nov 3, 2025
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 3, 2025

Summary of Changes

Hello @srinjoyray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request prepares several quickstart samples for the upcoming General Availability (GA) of Node.js 24 across various Google Cloud services. The changes primarily involve updating runtime and engine configurations to Node.js 24 and Ubuntu 24, ensuring the samples are compatible with the latest environments. Additionally, a .gcloudignore file is introduced to optimize deployments by preventing unnecessary files from being uploaded.

Highlights

  • Node.js Runtime Update: The App Engine Standard runtime for the 'building-an-app' sample has been updated from Node.js 20 to Node.js 24.
  • Node.js Engine Version: The required Node.js engine version in the 'building-an-app' sample's package.json has been updated from 20.x.x to 24.x.x.
  • Operating System Update: The operating system for the App Engine Flexible 'hello-world' sample has been updated from Ubuntu 22 to Ubuntu 24.
  • .gcloudignore Addition: A new .gcloudignore file has been added to the 'building-an-app' sample to exclude common development files like node_modules/, .git/, and .gitignore from deployments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js runtime to version 24 for the appengine/building-an-app/build and appengine/hello-world/flexible quickstart samples. The changes are correct and align with the goal of migrating to Node.js 24. I have one minor suggestion to add a final newline to the new .gcloudignore file. Additionally, I noticed that other quickstart samples like appengine/building-an-app/update and appengine/hello-world/standard are still configured for Node.js 20. To maintain consistency, you might consider updating these samples as well in this or a subsequent pull request.

@iennae iennae changed the title Update quickstart samples to Nodejs24 feature(run): Update quickstart samples to Nodejs24 Nov 4, 2025
@iennae iennae changed the title feature(run): Update quickstart samples to Nodejs24 feature(appengine): Update quickstart samples to Nodejs24 Nov 4, 2025
iennae
iennae approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only failure is due to genai samples issues unrelated to this change

@iennae iennae merged commit bf3beb0 into GoogleCloudPlatform:main Nov 4, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iennae iennae iennae approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: appengine Issues related to the App Engine Admin API API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srinjoyray @iennae